brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] brooklyn-ui pull request: Show config values when jumping from App...
Date Tue, 24 May 2016 12:02:11 GMT
GitHub user bostko opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/27

    Show config values when jumping from App Wizard to YAML Preview

    I hope the title explains what it is fixing
    ![screenshot from 2016-05-24 14-57-36](https://cloud.githubusercontent.com/assets/1595054/15502988/e3d15284-21bf-11e6-9789-9ead6782906c.png)
    
    I see that the `StepDeploy.validate` does more than validating the model.
    Any suggestions for separating this logic or renaming the validate method to `fillConfigAndValidate`?
    I do not understand how `ModalWizard`, `ModalWizard.StepCreate` and `ModalWizard.StepDeploy`
are connected to each other.
    @tbouron any comments?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/brooklyn-ui fix-preview-composed-yaml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit b6acf26fd43138e47e37ac816435b971ce5af71a
Author: Valentin Aitken <bostko@gmail.com>
Date:   2016-05-24T11:54:45Z

    Show config values when jumping from App Wizard to YAML Preview

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message