brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add dontRequireTtyForSude option to locations
Date Tue, 31 May 2016 12:18:57 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/brooklyn-server/pull/169

    Add dontRequireTtyForSude option to locations

    When using the `dontCreateUser` option on locations jclouds initialization won't run which
means it won't overwrite `/etc/sudoers` leaving in the defaults. For CentOS that means having
`requiretty` enabled. This will lead to all `sudo` calls from Brooklyn failing because we
are running without a session.
    It becomes even bigger problem because the `installDevUrandom` will fail (silently) and
the machine will be unresponsive for no apparent reason.
    
    The changes 
      * run the `/etc/sudoers` fix if explicitly requested or if `dontCreateUser` is set.
      * convert commands executed during location obtain to tasks so they are visible in the
acitivty tab
      * fails location obtaining on a non-0 exit code

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/brooklyn-server location-tty-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
    
----
commit b2cb9ac0fdf5c2640a93c7fa7747287c2802dd27
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2016-05-31T09:36:07Z

    Fail on non-0 exit code when setting up a location

commit bd165c125d5c9c89a7c2decbed8c6d6a181f9fa5
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2016-05-31T09:36:57Z

    Implement dontRequireTtyForSudo for locations
    
    Analogous to the SoftwareProcess behaviour, but applied when obtaining a location

commit 345915014315a106b64b2da6ace6b5460c3c0a80
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2016-05-31T11:58:19Z

    Execute location obtain commands as tasks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message