brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiuby88 <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Fix/required open ports
Date Wed, 11 May 2016 16:41:52 GMT
GitHub user kiuby88 opened a pull request:

    https://github.com/apache/brooklyn-server/pull/136

    Fix/required open ports

    This PR tries to fix the issue described by issue [BROOKLYN-263](  https://issues.apache.org/jira/browse/BROOKLYN-263).
    
    `BrooklynNode` requires `brooklynnode.webconsole.httpPort` config key as a open port.
However, the config was not being considered as a open port, because `InboundPortsUtils#getRequiredOpenPorts`
just consideres either config keys whose name matches with `*.port` or config keys that are
based on `PortRanges` and that are not configured (using default values).
    
    This PR adds to `InboundPortsUtils#getRequiredOpenPorts` the capability to take in account
explicit configured config keys that are based on `PortRanges`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiuby88/brooklyn-server fix/required-open-ports

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit b2ffcf242f670ef61b5b2b1d1f7e44b753f20c5e
Author: Kiuby88 <kiuby88.programming@gmail.com>
Date:   2016-05-11T16:19:19Z

    Check the required open port for BrooklynNode

commit 61d138e1a320ecf692686c8fae4b1585206217d3
Author: Kiuby88 <kiuby88.programming@gmail.com>
Date:   2016-05-11T16:21:49Z

    Inferring required open ports depending on config key value type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message