brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-275) Private Key Data description in the Add BYON Location Wizard is misleading
Date Wed, 25 May 2016 10:59:13 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299876#comment-15299876
] 

ASF GitHub Bot commented on BROOKLYN-275:
-----------------------------------------

GitHub user tbouron reopened a pull request:

    https://github.com/apache/brooklyn-ui/pull/28

    BROOKLYN-275: Location wizard generates valid YAML for multiline fields

    This update the field `privateKeyFile` to `privateKeyData`.
    
    It also checks if a configuration key contains line breaks. In that case, it will generate
a valid multiline YAML.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui fix/brooklyn-270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit f8db0de7c81dc7718068449c2013a571fab2d8fd
Author: Thomas Bouron <thomas.bouron@cloudsoftcorp.com>
Date:   2016-05-25T10:54:46Z

    Location wizard generates valid YAML for multiline fields

----


> Private Key Data description in the Add BYON Location Wizard is misleading
> --------------------------------------------------------------------------
>
>                 Key: BROOKLYN-275
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-275
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: John McCabe
>
> Attempting to add a BYON location via the Catalog wizard you are prompted for the following:
> {code}
> Private Key Data
> The contents of the private key file to use to connect to the machines (if using key
access, where the corresponding public key is in the .authorized_keys file on the servers)
> {code}
> This implies that you must paste the *contents* of your private key file however this
field is currently maping to {{privateKeyFile}} which takes a path to the key file on the
Brooklyn node FS.
> This needs to be updated to push the contents of the textarea to {{privateKeyData}}.
> *NOTE*: Also observed that if you paste a multi-line key it wasn't being indented correctly,
not sure if that was a result of populating the {{privateKeyFile}} tag (suspect not tho...),
we should handle multi-line key data as if the user copy-pastes from their private key file
thats what they'll be pasting, also needs to handle the begin/end comments in a standard private
key file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message