brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-273) VanillaSoftwareProcess.restart() should call pre- and post-launch
Date Tue, 24 May 2016 09:58:12 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298013#comment-15298013
] 

ASF GitHub Bot commented on BROOKLYN-273:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/149#discussion_r64362056
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
    @@ -53,7 +67,61 @@
         }
     
         @Override
    -    public <T> Maybe<T> getNonBlocking(ConfigKey<T> key) {
    +    public <T> Maybe<T> getNonBlocking(final ConfigKey<T> key) {
    +        if (key instanceof StructuredConfigKey || key instanceof SubElementConfigKey)
{
    +            return getNonBlockingResolvingStructuredKey(key);
    --- End diff --
    
    @neykov I wondered about using the same impl, but the problem is `getNonBlockingResolvingStructuredKey`
isn't a great implementation. If the thread executing the resolving task is starved, then
it could timeout even though the underlying task was not blocked. In contrast, the other code-path
will first check if the value needs resolved in a special way. If it does not, it will just
return the value directly. It is therefore more reliable!


> VanillaSoftwareProcess.restart() should call pre- and post-launch
> -----------------------------------------------------------------
>
>                 Key: BROOKLYN-273
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-273
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Aled Sage
>
> If calling restart() on a VanillaSoftwareProcess entity, to just restart the process,
it will call "launch" (skipping the install + customize phases).
> I'd expect the pre-launch and post-launch commands to also be executed, but they are
not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message