brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-273) VanillaSoftwareProcess.restart() should call pre- and post-launch
Date Fri, 20 May 2016 17:09:13 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293735#comment-15293735
] 

ASF GitHub Bot commented on BROOKLYN-273:
-----------------------------------------

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/149

    BROOKLYN-273: restart() calls pre-launch & post-launch

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-273

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit 8bfff1635c77affa19b9a33522ac1ab2ae6d2c8d
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-05-20T17:05:47Z

    Fix config().getNonBlocking for MapConfigKey
    
    Previously for MapConfigKey, the getNonBlocking would always return
    null. This could badly impacted VanillaSoftwareProcess, where 
    `VanillaSoftwareProcessSshDriver.getInstallLabelExtraSalt` would call
    this for SHELL_ENVIRONMENT. The shell env was therefore not included
    in the hash.

commit 13554d5cf433f1aeaab2be519e6698e2d85c5cdd
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-05-20T17:06:29Z

    Fix VanillaSoftwareProcessSshDriver.getInstallLabelExtraSalt
    
    Previously if download-url or install-command was blank, it would
    not continue to look at shell-env for computing the salt for the 
    install dir.

commit 8ab5dad045de08ca1fc3d06251ed015a5410e4fc
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-05-20T17:07:12Z

    BROOKLYN-273: restart() calls pre-launch & post-launch

----


> VanillaSoftwareProcess.restart() should call pre- and post-launch
> -----------------------------------------------------------------
>
>                 Key: BROOKLYN-273
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-273
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Aled Sage
>
> If calling restart() on a VanillaSoftwareProcess entity, to just restart the process,
it will call "launch" (skipping the install + customize phases).
> I'd expect the pre-launch and post-launch commands to also be executed, but they are
not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message