brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-270) BYON Location GUI Generates Bad-formatted YAML File
Date Wed, 25 May 2016 10:58:12 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299871#comment-15299871
] 

ASF GitHub Bot commented on BROOKLYN-270:
-----------------------------------------

GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/28

    BROOKLYN-270: Location wizard generates valid YAML for multiline fields

    This update the field `privateKeyFile` to `privateKeyData`.
    
    It also checks if a configuration key contains line breaks. In that case, it will generate
a valid multiline YAML.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui fix/brooklyn-270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit f8db0de7c81dc7718068449c2013a571fab2d8fd
Author: Thomas Bouron <thomas.bouron@cloudsoftcorp.com>
Date:   2016-05-25T10:54:46Z

    Location wizard generates valid YAML for multiline fields

----


> BYON Location GUI Generates Bad-formatted YAML File
> ---------------------------------------------------
>
>                 Key: BROOKLYN-270
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-270
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>         Environment: apache-brooklyn-0.9.0-bin on Mac OS X 10.11.4
>            Reporter: Mike Zaccardo
>              Labels: byon, gui
>
> When attempting to add a BYON location with a private key file through the GUI, the generated
YAML file is improperly formatted and results in the following error when the user tries to
save:
> ERROR Invalid YAML: while scanning a simple key; could not found expected ':'; in 'reader',
line 12, column 1: vfyF2M3xG3z5MUPuqeCveLhkI/1t26mW ... ^
> The location can only be added after the user manually fixes the formatting in the YAML
editor view.
> Here is a comparison of generated vs. manually fixed: https://gist.github.com/mikezaccardo/34ea0c38b232bf125a059f1b1913c486
> ^^ Note that the private key is a harmless / throwaway from a Vagrant box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message