brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add configuration option to SSH sens...
Date Sat, 28 May 2016 14:58:03 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/127#discussion_r64989872
  
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshFeed.java ---
    @@ -267,13 +261,13 @@ public SshPollValue call() throws Exception {
         
         private SshPollValue exec(String command, Map<String,String> env) throws IOException
{
             SshMachineLocation machine = getMachine();
    -        Boolean execAsCommand = getConfig(EXEC_AS_COMMAND);
    +        Boolean execAsCommand = config().get(EXEC_AS_COMMAND);
             if (log.isTraceEnabled()) log.trace("Ssh polling for {}, executing {} with env
{}", new Object[] {machine, command, env});
             ByteArrayOutputStream stdout = new ByteArrayOutputStream();
             ByteArrayOutputStream stderr = new ByteArrayOutputStream();
     
             int exitStatus;
    -        ConfigBag flags = ConfigBag.newInstance()
    +        ConfigBag flags = ConfigBag.newInstanceExtending(config().getBag())
    --- End diff --
    
    @grkvlt this change sneaked in without comment ;-)
    It looks reasonable (though the config on the feed will normally not be low-level ssh
config, I'd guess). But could you comment on it to say why, and to confirm it is deliberate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message