brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Resolve AddSensor and AddEffector co...
Date Thu, 26 May 2016 16:35:51 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/152#discussion_r64778305
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/password/CreatePasswordSensor.java
---
    @@ -33,23 +34,21 @@
     
         public static final ConfigKey<String> ACCEPTABLE_CHARS = ConfigKeys.newStringConfigKey("password.chars",
"The characters allowed in password");
     
    -    private Integer passwordLength;
    -    private String acceptableChars;
    -
         public CreatePasswordSensor(Map<String, String> params) {
             this(ConfigBag.newInstance(params));
         }
     
         public CreatePasswordSensor(ConfigBag params) {
             super(params);
    -        passwordLength = params.get(PASSWORD_LENGTH);
    -        acceptableChars = params.get(ACCEPTABLE_CHARS);
         }
     
         @Override
         public void apply(EntityLocal entity) {
             super.apply(entity);
     
    +        Integer passwordLength = EntityInitializers.resolve(params, PASSWORD_LENGTH);
    +        String acceptableChars = EntityInitializers.resolve(params, ACCEPTABLE_CHARS);
    --- End diff --
    
    You're right, this was lazy of me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message