brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Ability to suppress install command ...
Date Tue, 24 May 2016 12:11:58 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/150#discussion_r64379212
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/WinRmExecuteHelper.java
---
    @@ -82,16 +82,29 @@ public WinRmExecuteHelper setPsCommand(String psCommand) {
          * _and_ block until completion, throwing on error */
         @Beta
         public Task<Integer> queue() {
    -        return DynamicTasks.queueIfPossible(newTask()).orSubmitAndBlock().getTask();
    +        return queue(false);
    +    }
    +
    +    private Task<Integer> queue(boolean suppressFailures) {
    --- End diff --
    
    Again, why is `suppressFailures` a parameter on `queue()`, rather than config you can
set on the `WinRmExecuteHelper`? I'd favour adding a method `suppressFailures(boolean)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message