brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Ability to suppress install command ...
Date Tue, 24 May 2016 12:05:42 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/150#discussion_r64378283
  
    --- Diff: software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java
---
    @@ -46,7 +46,7 @@
         ConfigKey<String> PROP_HOST = newStringConfigKey("host", "Host to connect to
(required)", null);
         ConfigKey<Integer> PROP_PORT = ConfigKeys.newIntegerConfigKey("port", "WinRM
port to use when connecting to the remote machine");
         ConfigKey<Boolean> USE_HTTPS_WINRM = ConfigKeys.newBooleanConfigKey("winrm.useHttps",
"The parameter tells the machine sensors whether the winrm port is over https. If the parameter
is true then 5986 will be used as a winrm port.", false);
    -    ConfigKey<Integer> RETRIES_OF_NETWORK_FAILURES = ConfigKeys.newIntegerConfigKey("retriesOfNetworkFailures",
"The parameter sets the number of retries for connection failures. If you use high value,
consider taking care for the machine's network.");
    +    ConfigKey<Integer> RETRIES_OF_NETWORK_FAILURES = ConfigKeys.newIntegerConfigKey("retriesOfNetworkFailures",
"The parameter sets the number of retries for connection failures. If you use high value,
consider taking care for the machine's network.", 4);
    --- End diff --
    
    Remind me: are we careful where we use this retry for non-idempotent commands (e.g. in
case the command was received and partially executed before we got the network failure, which
is presumably indistinguishable from the command never been started)? In such as case, do
we still retry or do we refuse to retry?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message