brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Merge Map values in Location config
Date Tue, 24 May 2016 11:55:38 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/151#discussion_r64376720
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
    @@ -126,7 +126,11 @@ public void markUsed(String key) {
         /** As {@link #newInstanceExtending(ConfigBag)} but also putting the supplied values.
*/
         @Beta
         public static ConfigBag newInstanceExtending(final ConfigBag configBag, Map<?,?>
optionalAdditionalValues) {
    -        return newInstanceExtending(configBag).putAll(optionalAdditionalValues);
    --- End diff --
    
    As per @neykov 's comments, do we really want this change?
    
        I think we shouldn't do this, too intrusive. Better make the merging behaviour specific
to provisioning.properties.
        Or even more constrained to templateOptions.
        I like the idea of the PR, but feel that it should be more constrained in scope. Either
having this behaviour only for prosivioning.properties or even more to templateOptions
    
    It feels high risk. It's unclear what impact it will have on other users (e.g. someone
writing a YAML entity that extends another entity, overriding a config key; for that particular
example, we need to discuss it on dev@brooklyn a lot more first).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message