brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: BROOKLYN-273: restart() calls pre-la...
Date Tue, 24 May 2016 09:57:20 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/149#discussion_r64362056
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
    @@ -53,7 +67,61 @@
         }
     
         @Override
    -    public <T> Maybe<T> getNonBlocking(ConfigKey<T> key) {
    +    public <T> Maybe<T> getNonBlocking(final ConfigKey<T> key) {
    +        if (key instanceof StructuredConfigKey || key instanceof SubElementConfigKey)
{
    +            return getNonBlockingResolvingStructuredKey(key);
    --- End diff --
    
    @neykov I wondered about using the same impl, but the problem is `getNonBlockingResolvingStructuredKey`
isn't a great implementation. If the thread executing the resolving task is starved, then
it could timeout even though the underlying task was not blocked. In contrast, the other code-path
will first check if the value needs resolved in a special way. If it does not, it will just
return the value directly. It is therefore more reliable!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message