brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: BROOKLYN-273: restart() calls pre-la...
Date Tue, 24 May 2016 09:17:00 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/149#discussion_r64355530
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
    @@ -53,7 +67,61 @@
         }
     
         @Override
    -    public <T> Maybe<T> getNonBlocking(ConfigKey<T> key) {
    +    public <T> Maybe<T> getNonBlocking(final ConfigKey<T> key) {
    +        if (key instanceof StructuredConfigKey || key instanceof SubElementConfigKey)
{
    +            return getNonBlockingResolvingStructuredKey(key);
    --- End diff --
    
    Could use this implementation for both cases to simplify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message