brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Fix BROOKLYN-268: DynamicCluster on-...
Date Wed, 18 May 2016 13:59:22 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/140#issuecomment-220034504
  
    @kiuby88 unfortunately the test seems to be non-deterministic (without this fix). That
is presumably because there is a race between the enricher setting the service.isUp to null,
and DynamicClusterImpl explicitly setting the service.isUp to true.
    
    Thanks for reviewing!
    
    @ahgittin any comments on this (and the subtleties of the `ServiceStateLogic`)? Or is
this good to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message