brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add configuration option to SSH sens...
Date Mon, 16 May 2016 14:33:42 GMT
Github user grkvlt commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/127#issuecomment-219440569
  
    @ahgittin @neykov finally had a look at this, and turns out that in `TypeCoercions` we
already call `value.trim()` in the `stringToPrimitive()` method. It's really only a problem
when we want the output of the SSH command to _remain_ as string sensor data, that may be
getting processed elsewhere, and in that case we just want to remove the final `\n` that is
getting added. We _could_ have added something [here](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/util/core/flags/TypeCoercions.java#L175)
where we would check if `targetType instanceof String` but not convinced now that this is
the right solution. But, since the issue only occurs in SSH command based sensors, I have
just added a call to `Strings.trimEnd()` which is null-safe, and removed the configuration
option for trimming entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message