brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiuby88 <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Fix/required open ports
Date Fri, 13 May 2016 09:32:40 GMT
Github user kiuby88 commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/136#discussion_r63156360
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/InboundPortsUtils.java
---
    @@ -77,12 +82,17 @@
                 Set<ConfigKey<?>> configKeys = Sets.newHashSet(extraConfigKeys);
                 configKeys.addAll(entity.getEntityType().getConfigKeys());
                 // Also add dynamically added config keys
    -            configKeys.addAll(((EntityInternal)entity).config().getBag().getAllConfigAsConfigKeyMap().keySet());
    +            Map<ConfigKey<?>, ?> configuredConfigKeys = ImmutableMap.copyOf(((EntityInternal)
entity).config().getBag().getAllConfigAsConfigKeyMap());
    +            configKeys.addAll(configuredConfigKeys.keySet());
    +
    +            if (portRegex == null) {
    +                portRegex = ".*\\.port"; // defaults to legacy regex if not specified
    +            }
    --- End diff --
    
    Ok, let me roll back the aforementioned changes



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message