brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] brooklyn-server pull request: Fix/required open ports
Date Fri, 13 May 2016 08:56:33 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/
    @@ -77,12 +82,17 @@
                 Set<ConfigKey<?>> configKeys = Sets.newHashSet(extraConfigKeys);
                 // Also add dynamically added config keys
    -            configKeys.addAll(((EntityInternal)entity).config().getBag().getAllConfigAsConfigKeyMap().keySet());
    +            Map<ConfigKey<?>, ?> configuredConfigKeys = ImmutableMap.copyOf(((EntityInternal)
    +            configKeys.addAll(configuredConfigKeys.keySet());
    --- End diff --
    why create the intermediate `Immutable`?  is there a risk if a value in the may is null
that it will now throw NPE?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message