brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-docs pull request: Update the tests documentation
Date Mon, 09 May 2016 18:17:26 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/55#discussion_r62546531
  
    --- Diff: guide/yaml/test/test-entities.md ---
    @@ -89,6 +93,10 @@ The `TestEffector` entity invokes the specified effector on a target
entity. If
     - `params` - parameters to pass to the effector, these will depend on the entity and
effector being tested. The example above shows the `url` and `targetName` parameters being
passed to Tomcats `deploy` effector.
     - `assert` - assertion to perform on the returned result. See section on assertions below.
     
    +<div class="alert alert-info">
    --- End diff --
    
    this would be a good candidate for a partial/include following the pattern of `_includes/feature-item.html`
as used in `website//learnmore/features/*.md` -- you could just write
    
        {% include tip-testcase.html title="TestEffector" %}
    
    also curious why you're using html rather than md syntax
    
    but both comments are pedantic, feel free to ignore
    
    merging
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message