brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...
Date Mon, 09 May 2016 14:08:47 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/132#discussion_r62503400
  
    --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
    @@ -147,8 +168,21 @@ public void init() {
             }
             config().set(MACHINE_SPECS, (List<LocationSpec<? extends MachineLocation>>)
null);
             
    +        Supplier<? extends List<? extends MachineLocation>> initialMachinesFactory
= getConfig(INITIAL_MACHINES_FACTORY);
    +        if (initialMachinesFactory != null) {
    +            List<? extends MachineLocation> initialMachines = initialMachinesFactory.get();
    +            if (initialMachines != null) {
    +                for (MachineLocation machine : initialMachines) {
    +                    @SuppressWarnings("unchecked")
    +                    T castMachine = (T) machine;
    +                    machines.add(castMachine);
    --- End diff --
    
    Probably worth checking that `machine` is not null too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message