brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL
Date Thu, 05 May 2016 22:14:32 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/33#discussion_r62264240
  
    --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java
---
    @@ -328,9 +340,39 @@ private void initializeNewDatabase() {
                             " --command="+ createUserCommand),
                     sudoAsUser("postgres", getInstallDir() + "/bin/psql -p " + entity.getAttribute(PostgreSqlNode.POSTGRESQL_PORT)
+ 
                                     " --command="+ createDatabaseCommand),
    +                createRolesAdditionalCommand,
                     callPgctl("stop", true))
                     .failOnNonZeroResultCode().execute();
         }
    +
    +    private String buildCreateRolesQuery() {
    +        Map<String, Map> roles = entity.getConfig(PostgreSqlNode.ROLES);
    +        String createRolesQuery = "\"";
    +
    +        for (Map.Entry role: roles.entrySet()) {
    +            createRolesQuery = createRolesQuery.concat(String.format("CREATE ROLE %s",
role.getKey()));
    --- End diff --
    
    Here and below, you shouldn't create SQL statements using string concatenation, that leaves
you wide open to SQL injection attacks.  Instead use a prepared statement with appropriate
bind variables, if at all possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message