brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Configurable removal strategies
Date Thu, 05 May 2016 19:22:39 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/112#discussion_r62239950
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java
---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.entity.group;
    +
    +import java.util.Collection;
    +import java.util.List;
    +
    +import javax.annotation.Nullable;
    +
    +import org.apache.brooklyn.api.entity.Entity;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +
    +import com.google.common.collect.Iterables;
    +import com.google.common.reflect.TypeToken;
    +
    +public class FirstFromRemovalStrategy extends RemovalStrategy {
    +
    +    public static final ConfigKey<List<RemovalStrategy>> STRATEGIES = ConfigKeys.newConfigKey(new
TypeToken<List<RemovalStrategy>>() {}, "firstfrom.strategies",
    +            "An ordered list of removal strategies to be used to determine which entity
to remove");
    +
    +    @Nullable
    +    @Override
    +    public Entity apply(@Nullable Collection<Entity> input) {
    +        List<RemovalStrategy> strategies = config().get(STRATEGIES);
    --- End diff --
    
    Following up on @neykov's point - from a yaml perspective, how would one use this currently?
What is the advantage of having `RemovalStrategy extends BasicConfigurableObject`? Are you
expecting people to use (in yaml) the `$brooklyn:object` syntax to instantiate the removal
strategy? (if so, they can use `brooklyn.config` within the `$brooklyn:object:`). I still
don't see the benefit of that over a pojo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message