brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Configurable removal strategies
Date Thu, 05 May 2016 18:04:06 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/112#discussion_r62227490
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java
---
    @@ -151,12 +151,14 @@ public ZoneFailureDetector apply(final String input) {
          */
         protected final Object mutex = new Object[0];
     
    -    private static final Function<Collection<Entity>, Entity> defaultRemovalStrategy
= new Function<Collection<Entity>, Entity>() {
    -        @Override public Entity apply(Collection<Entity> contenders) {
    --- End diff --
    
    Agreed, let's be paranoid. Mark it as deprecated, with a comment saying why we have not
deleted it.
    
    There are two ways changing your anonymous inner class can break persistence: one is if
someone has persisted it; two is if deleted or moving the class changes the classnames of
other anonymous inner classes (there are 5 of them in DynamicClusterImpl)!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message