brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add method HttpFeed.Builder#credenti...
Date Thu, 05 May 2016 17:51:38 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/119#discussion_r62225338
  
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
    @@ -197,6 +197,10 @@ public Builder credentials(String username, String password) {
                 this.credentials = new UsernamePasswordCredentials(username, password);
                 return this;
             }
    +        public Builder credentials(Credentials credentials) {
    --- End diff --
    
    Not sure about this. Nothing in the HttpFeed's public API talks about `org.apache.http.auth`.
If we add this public method, then `org.apache.http.auth.Credentials` is exposed (rather than
it being an implementation detail).
    
    Mind you, some of our other "public" classes (e.g. `HttpTool`) exposes `org.apache.http.*`
in its API.
    
    What is the use-case for adding this?
    
    @rdowner what are your thoughts - should we expose this in the API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message