Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-107-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-107-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: [OSGi] Load properties from
 config a...
Content-Type: text/plain
Message-Id: <20160412131619.D1F67DFF13@git1-us-west.apache.org>
Date: Tue, 12 Apr 2016 13:16:19 +0000 (UTC)

Github user geomacy commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/107#issuecomment-208900076
  
    👍  I've read through the code and don't have any particular comments to make, I also pulled and built the branch and confirmed that brooklyn.cfg is read and properties from it are used to configure Brooklyn and are dynamically updatable via the config:properties-set command in Karaf console.  
    
    In its present form this will read properties, separately, from the global and local files, and from etc/brooklyn.cfg, and you can only see the values from brooklyn.cfg in the karaf console.  It might be interesting to discuss whether all values could be brought into Configuration Admin and managed from there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---