Return-Path: 
 <dev-return-15047-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7676319446
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Tue, 12 Apr 2016 10:42:20 +0000 (UTC)
Received: (qmail 71158 invoked by uid 500); 12 Apr 2016 10:42:20 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 71129 invoked by uid 500); 12 Apr 2016 10:42:20 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 71118 invoked by uid 99); 12 Apr 2016 10:42:20 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 10:42:20 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 03715DFF10; Tue, 12 Apr 2016 10:42:20 +0000 (UTC)
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-112-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-112-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: Configurable removal
 strategies
Content-Type: text/plain
Message-Id: <20160412104220.03715DFF10@git1-us-west.apache.org>
Date: Tue, 12 Apr 2016 10:42:20 +0000 (UTC)

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/112#discussion_r59355280
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java ---
    @@ -148,6 +148,11 @@
         ConfigKey<EntityFactory> FACTORY = ConfigKeys.newConfigKey(
                 EntityFactory.class, "dynamiccluster.factory", "factory for creating new cluster members", null);
     
    +
    +    @SetFromFlag("removalStrategy")
    --- End diff --
    
    `@SetFromFlag("removalStrategy")` is on both this and the deprecated key. Which one wins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---