Return-Path: 
 <dev-return-15012-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 47EC919AAD
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon, 11 Apr 2016 11:06:53 +0000 (UTC)
Received: (qmail 38654 invoked by uid 500); 11 Apr 2016 11:06:53 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 38623 invoked by uid 500); 11 Apr 2016 11:06:53 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 38612 invoked by uid 99); 11 Apr 2016 11:06:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 11:06:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id CB998DFDE0; Mon, 11 Apr 2016 11:06:52 +0000 (UTC)
From: bostko <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-110-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-110-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: Verify windows up time
 parameter.
Content-Type: text/plain
Message-Id: <20160411110652.CB998DFDE0@git1-us-west.apache.org>
Date: Mon, 11 Apr 2016 11:06:52 +0000 (UTC)

Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/110#discussion_r59187335
  
    --- Diff: software/winrm/src/main/java/org/apache/brooklyn/location/winrm/WinRmMachineLocation.java ---
    @@ -80,6 +81,9 @@
         public static final ConfigKey<String> OPERATION_TIMEOUT = newConfigKeyWithPrefix(BrooklynConfigKeys.BROOKLYN_WINRM_CONFIG_KEY_PREFIX, WinRmTool.OPERATION_TIMEOUT);
         public static final ConfigKey<Integer> RETRIES_OF_NETWORK_FAILURES = newConfigKeyWithPrefix(BrooklynConfigKeys.BROOKLYN_WINRM_CONFIG_KEY_PREFIX, WinRmTool.RETRIES_OF_NETWORK_FAILURES);
         public static final ConfigKey<Boolean> USE_HTTPS_WINRM = WinRmTool.USE_HTTPS_WINRM;
    +    public static final ConfigKey<String> VERIFY_WINDOWS_UP = newStringConfigKey("verifyWindowsUp",
    +            "Sometimes restart could happen after a Windows VM is provisioned. This could be because of System Upgrade or other." +
    +            " Brooklyn will wait 5 minutes for a restart to happen before returning the machine as accessible.", "5m");
    --- End diff --
    
    Ok I agree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---