brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: BROOKLYN-257: allow nulling imageId ...
Date Sat, 16 Apr 2016 20:26:36 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/115

    BROOKLYN-257: allow nulling imageId in jcloudsLocation.obtain()

    Fixes https://issues.apache.org/jira/browse/BROOKLYN-257.
    
    To fix this, I was tempted to instead change `JcloudsLocation.buildTemplate` so that it
ignored all null values, changing the code below:
    
    ```
            for (Map.Entry<ConfigKey<?>, CustomizeTemplateBuilder> entry : SUPPORTED_TEMPLATE_BUILDER_PROPERTIES.entrySet())
{
                ConfigKey<?> name = entry.getKey();
                CustomizeTemplateBuilder code = entry.getValue();
                if (config.containsKey(name))
                    code.apply(templateBuilder, config, config.get(name));
            }
    ```
    
    to:
    
    ```
            for (Map.Entry<ConfigKey<?>, CustomizeTemplateBuilder> entry : SUPPORTED_TEMPLATE_BUILDER_PROPERTIES.entrySet())
{
                ConfigKey<?> name = entry.getKey();
                CustomizeTemplateBuilder code = entry.getValue();
                if (config.containsKey(name) && config.get(name) != null)
                    code.apply(templateBuilder, config, config.get(name));
            }
    ```
    
    But is that risky? Do we rely for any config keys on `null` meaning something other than
"use the jclouds default"?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix/imageId-overriding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit d5a01b23ec38b7f6e3faba9b7b6ef45257113d55
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-04-16T20:19:12Z

    BROOKLYN-257: allow nulling imageId in jcloudsLocation.obtain()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message