brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-250) displayName in location brooklyn.config not being used
Date Mon, 11 Apr 2016 11:27:25 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234900#comment-15234900
] 

ASF GitHub Bot commented on BROOKLYN-250:
-----------------------------------------

GitHub user johnmccabe opened a pull request:

    https://github.com/apache/brooklyn-server/pull/111

    fixes BROOKLYN-250

    Untyped config from the YAML is being pushed into flags rather than config, so rather
than expose flags in the locations API (which we're moving away from to the catalog API),
I'm now checking for the presence of a displayName parameter in flags and setting it in the
LocationTransformer.
    
    Tests added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnmccabe/brooklyn-server fix/BROOKLYN-250

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 049c852ed0f48435836a061bf3f3745cdd850f8f
Author: John McCabe <john@johnmccabe.net>
Date:   2016-04-11T11:24:45Z

    fixes BROOKLYN-250
    - config is being pushed into flags, so rather than expose flags in the locations API
(which we're moving away from to the catalog API), I'm now checking for the presence of a
displayName parameter in flags and setting it in the LocationTransformer.

----


> displayName in location brooklyn.config not being used
> ------------------------------------------------------
>
>                 Key: BROOKLYN-250
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-250
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: John McCabe
>            Priority: Minor
>         Attachments: catalog.png, dropdown.png
>
>
> Observed that the {{displayName}} field populated by the location wizard/yaml doesn't
appear to be used? For example:
> {code}
> brooklyn.catalog:
>   items:
>   - id: locationid
>     itemType: location
>     item:
>       type: localhost
>       brooklyn.config:
>         displayName: locationname
> {code}
> displays as {{locationid}} rather than {{locationname}} (in dropdown lists and the catalog
page), whereas the following
> {code}
> brooklyn.catalog:
>   items:
>   - id: locationid
>     itemType: location
>     name: locationname
>     item:
>       type: localhost
> {code}
> displays the string set in the {{name}} element.
> If {{name}} isn't present it falls back to using the {{id}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message