brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <>
Subject [GitHub] brooklyn-client pull request: Adds support for Plugins
Date Wed, 27 Apr 2016 16:25:17 GMT
Github user geomacy commented on a diff in the pull request:
    --- Diff: command_runner/runner.go ---
    @@ -29,14 +30,22 @@ type Runner interface {
     	RunSubCmdByName(cmdName string, subCommand string, c *cli.Context) (err error)
    +type Factory interface {
    --- End diff --
    Hm, that suggests we maybe need a refactor to bring commonly required code into a lower
level that will break the circular dependency. I think it would be really nice to avoid the
duplication (triplication!) of interfaces.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message