brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add reading of default.catalog.bom.
Date Fri, 22 Apr 2016 13:18:45 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/120#discussion_r60736795
  
    --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiLauncher.java
---
    @@ -38,6 +39,7 @@
     public class OsgiLauncher extends BasicLauncher<OsgiLauncher> {
     
         private static final Logger LOG = LoggerFactory.getLogger(OsgiLauncher.class);
    +    private static final String DEFAULT_CATALOG_BOM = "file:conf/brooklyn/default.catalog.bom";
    --- End diff --
    
    I did think about that and wasn't sure.  In the end I plumped for `conf` in order to keep
the file location the same as for the classic launcher, but didn't feel very strongly that
this was the clear choice.  If you think it's probably better to 'go the Karaf way' at the
expense of a little backward compatibility then I'll change this.  Karaf is already quite
different from classic in many ways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message