brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Configurable removal strategies
Date Wed, 13 Apr 2016 13:52:09 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/112#discussion_r59550901
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java
---
    @@ -151,12 +151,14 @@ public ZoneFailureDetector apply(final String input) {
          */
         protected final Object mutex = new Object[0];
     
    -    private static final Function<Collection<Entity>, Entity> defaultRemovalStrategy
= new Function<Collection<Entity>, Entity>() {
    -        @Override public Entity apply(Collection<Entity> contenders) {
    --- End diff --
    
    Rule of thumb is that anything that goes into a config or sensor (or is nested in such
an object) will get persisted. Looking at the code this is not the case, but can never know
what an extending class might be doing, so better be on the safe side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message