brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Add catalog.bom application white/bl...
Date Wed, 13 Apr 2016 12:57:10 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/106#discussion_r59542324
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java
---
    @@ -168,11 +227,18 @@ private String addLibraryDetails(Bundle bundle, String bomText)
{
                         LOG.warn("Unexpected syntax for {} (expected Map), ignoring", BROOKLYN_CATALOG);
                     }
                 }
    -            final String updatedBom = new Yaml().dump(bom);
    +            final String updatedBom = backToYaml(bom);
    --- End diff --
    
    Something that I didn't consider before when discussing this approach is that parsing
and re-serializing the yaml will change its formatting. Not a problem for Brooklyn internals,
but will be surprising to users when viewing the plan in the catalog. Not to be addressed
in this PR, but we should keep it in mind.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message