brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: Configurable removal strategies
Date Tue, 12 Apr 2016 13:56:10 GMT
Github user sjcorbett commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/112#issuecomment-208918399
  
    Looks much cleaner. I'm wary that turning `defaultRemovalStrategy` from an anonymous inner
class to a named inner class will be problematic for anyone with persisted state (because
the `$1`, `$2` etc. numbering will change). Given that it's not imperative for this feature
are you ok to revert that particular portion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message