brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <>
Subject [GitHub] brooklyn-server pull request: [OSGi] Load properties from config a...
Date Tue, 12 Apr 2016 13:35:10 GMT
Github user m4rkmckenna commented on a diff in the pull request:
    --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/
    @@ -23,36 +26,78 @@
     import org.apache.brooklyn.core.internal.BrooklynProperties;
     import org.apache.brooklyn.core.mgmt.persist.PersistMode;
     import org.apache.brooklyn.launcher.common.BasicLauncher;
    +import org.apache.brooklyn.launcher.common.BrooklynPropertiesFactoryHelper;
    +import org.apache.brooklyn.util.exceptions.Exceptions;
     import org.apache.brooklyn.util.javalang.Threads;
    +import org.apache.brooklyn.util.text.Strings;
     import org.apache.brooklyn.util.time.Duration;
    +import org.osgi.framework.Constants;
    +import org.osgi.framework.InvalidSyntaxException;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
      * Initializer for brooklyn-core when running in an OSGi environment.
    - *
    - * Temporarily here; should be totally contained in blueprint beans' init-methods.
     public class OsgiLauncher extends BasicLauncher<OsgiLauncher> {
         private static final Logger LOG = LoggerFactory.getLogger(OsgiLauncher.class);
    +    public static final String BROOKLYN_CONFIG_PID = "brooklyn";
    --- End diff --
    IMO the PID should be `org.apacha.brooklyn`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message