brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andreaturli <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: New PerUserEntitlementManager keywor...
Date Fri, 08 Apr 2016 10:28:01 GMT
Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/108#discussion_r59006658
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/Entitlements.java
---
    @@ -398,15 +420,17 @@ public static void clearEntitlementContext() {
          * @since 0.7.0
          * @deprecated since 0.7.0, use {@link #checkEntitled(EntitlementManager, EntitlementClass,
Object)};
          * kept briefly because there is some downstream usage*/
    +    // Note: @Deprecated annotation only added from v0.10.0.
    +    @Deprecated
         public static <T> void requireEntitled(EntitlementManager checker, EntitlementClass<T>
permission, T typeArgument) {
             checkEntitled(checker, permission, typeArgument);
         }
         
         // ----------------- initialization ----------------
     
         public final static String ENTITLEMENTS_CONFIG_PREFIX = "brooklyn.entitlements";
    -    
    -    public static ConfigKey<String> GLOBAL_ENTITLEMENT_MANAGER = ConfigKeys.newStringConfigKey(ENTITLEMENTS_CONFIG_PREFIX+".global",

    +
    +    public static final ConfigKey<String> GLOBAL_ENTITLEMENT_MANAGER = ConfigKeys.newStringConfigKey(ENTITLEMENTS_CONFIG_PREFIX
+ ".global",
             "Class for entitlements in effect globally; "
             + "short names 'minimal', 'readonly', or 'root' are permitted here, with the
default 'root' giving full access to all declared users; "
    --- End diff --
    
    shall we add `user` or the description doesn't need to be exhaustive?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message