brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: BROOKLYN-245: improve synchronizatio...
Date Fri, 01 Apr 2016 08:13:35 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/96#discussion_r58174628
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java ---
    @@ -1484,9 +1484,11 @@ public void unsubscribeAll() {
             }
             
             protected SubscriptionContext getSubscriptionContext() {
    -            synchronized (AbstractEntity.this) {
    -                return getManagementSupport().getSubscriptionContext();
    -            }
    --- End diff --
    
    fix looks good, agree `EMS` handles synching is sufficient and means we should not try
to do so here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message