brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: a few more OSGi fixes
Date Fri, 01 Apr 2016 07:59:12 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/93#issuecomment-204299320
  
    @m4rkmckenna @CMoH what are your views on logging?
    
    the existing logback config has a few nice features including rollover configuration and
good categories for jclouds and nicely formatted messages and custom filenames -- and integration
so you get good logging during tests and running in the IDE (without which the IDE can be
painful) -- so if we can support it that's definitely my preference, but only if it doesn't
feel too odd.
    
    otoh i don't want to waste time fighting karaf so if log4j is the de facto standard in
osgi or logback completely alien then we should switch.  but the existence of `pax-logging-logback`
suggests it might not be a completely strange thing to do.
    
    @neykov regarding the point that the current `logback.xml` in the dist references e.g.
`logging/some-project/logback-partial.xml` that makes me wonder how osgi logging is meant
to work:
    
    * does a master `logback.xml` define categories applying to every bundle (eg configured
in `o.o.p.logging.logback.config.file`)?
    
    * if this references other files what is the search path?  (an extension bundle is a great
idea, if it works.  if so it doesn't feel too difficult.  alternately we could use maven to
copy the items from that bundle and put them in the right structure in the dist; that might
be preferable in any case.)
    
    * can we define additional logging config on a per-bundle basis?  (i'm not sure we'd do
that even if we could, but maybe it would show us a cleaner way.)
    
    running in the IDE w nice logging is quite important i think -- debug gets painful otherwise
-- so that should be a consideration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message