Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-61-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-61-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: BrooklynNode: support initial
 catalo...
Content-Type: text/plain
Message-Id: <20160314164203.25418DFC11@git1-us-west.apache.org>
Date: Mon, 14 Mar 2016 16:42:03 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/61#discussion_r56031864
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/BrooklynNodeSshDriver.java ---
    @@ -224,8 +231,18 @@ public void customize() {
                 uploadFileContents(brooklynLocalPropertiesContents, brooklynLocalPropertiesUri, brooklynLocalPropertiesRemotePath);
             }
     
    +        // Upload a local-catalog.bom if required
    +        if (brooklynCatalogInitialBomContents != null || brooklynCatalogInitialBomUri != null) {
    +            uploadFileContents(brooklynCatalogInitialBomContents, brooklynCatalogInitialBomUri, brooklynCatalogInitialBomRemotePath);
    +        }
    +
             // Override the ~/.brooklyn/catalog.xml if required
             if (brooklynCatalogContents != null || brooklynCatalogUri != null) {
    +            log.warn("Deprecated use of config"
    --- End diff --
    
    Add `Deprecated since x.x.x`. Looking at the config keys it would be `0.7.0`, but since that's not user visible might make sense to set it to 0.9.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---