Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-4-brooklyn-client@git.apache.org>
In-Reply-To: <git-pr-4-brooklyn-client@git.apache.org>
Subject: [GitHub] brooklyn-client pull request: Add -Pno-go-client profile
Content-Type: text/plain
Message-Id: <20160310094625.AE364DFBDB@git1-us-west.apache.org>
Date: Thu, 10 Mar 2016 09:46:25 +0000 (UTC)

Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/4#issuecomment-194759161
  
    A wrapper module doesn't bring much to the table, makes the build more complex I think. You'd need the same workarounds elsewhere to depend on the artifact and to activate the profile for the modules.
    
    The important thing is that we don't generate an empty zip file. Whether there's a pom file uploaded to artifactory doesn't really matter (for the client module).
    
    Also keep in mind we'd need the same workarounds for the rpm build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---