brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-ui pull request: Show error message on top of the YAML ed...
Date Wed, 23 Mar 2016 11:15:12 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/21#discussion_r57142670
  
    --- Diff: src/main/webapp/assets/tpl/editor/page.html ---
    @@ -47,12 +47,12 @@ <h3 style="margin-top: 6px;">Blueprint Composer</h3>
                         </span>
                     </div>
                 </div>
    +            <div class="error-message label-message hide" style="display:none;">
    +                <div class="label-important">ERROR</div>
    +                <span class="error-message-text"></span>
    +            </div>
                 <div class="navbar_main_wrapper">
                     <div class="navbar_main">
    -                    <div class="error-message label-message hide" style="display:none;">
    --- End diff --
    
    No need for the `style="display:none;"` as the `hide` class already does it
    
    Also I would remove the `label-message` class as the style of it does not match the current
look & feel of the editor. Instead, you can customise the `error-message` class like so:
    ```css
    .error-message {
        background-color: #e2e2e2;
        padding: 15px 10px 15px 10px;
        border-left: 1px solid #d3d3d3;
        border-right: 1px solid #d3d3d3;
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message