brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...
Date Thu, 17 Mar 2016 15:24:40 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/70#issuecomment-197930852
  
    Having looked at https://github.com/apache/incubator-brooklyn/pull/1124 I think @bostko
is right, this does not address a leak where a `Location` is created and passed to an `Entity`
as a `start` argument.
    
    Feels like we should do further work to accept `LocationSpec` objects -- or strings etc
-- as arguments to `start(...)`, and record explicitly whether an entity is creating the locations
(eg using new relationships support -- if that is persisted?). /cc @bostko @aledsage @neykov


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message