brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdowner <...@git.apache.org>
Subject [GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Date Fri, 11 Mar 2016 14:29:41 GMT
Github user rdowner commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195388591
  
    Ok I have it working now :smile: the good news is that once I had the RPM, installing
it was dead easy, and I instantly had a working, password-protected, remotely-accessible Brooklyn
service running on port 8081. Which is brilliant!
    
    My comments:
    
    * The architecture is appearing as `i386`. Since the package contains pure Java, could
we use `noarch` instead?
    * The file `/etc/brooklyn/logback.xml` is not being loaded - log files are being written
to /opt/brooklyn. Not sure of the best way to fix this; could the package replace `/opt/brooklyn/conf/logback.xml`
with ` symlink to `/etc/brooklyn/logback.xml`?
    
    And a question: when I run `rpm -qi apache-brooklyn` I see this:
    
    ```
    Name        : apache-brooklyn
    Version     : 0.9.0
    Release     : SNAPSHOT20160311140805
    ...
    ```
    
    I'm a bit concerned by `Version: 0.9.0` and `SNAPSHOT` in the release part. Is there any
danger that there could be any confusion over this? e.g. if I install 0.9.0-SNAPSHOT, but
then later on 0.9.0 (final) comes out, will it accidentally think the `SNAPSHOT` release is
"newer"?
    
    Finally, I notice the `br` client is not there. I presume that is deliberate - that an
operator would download the `br` client only to his machine and run it there, instead of on
the server?
    
    Great work @alrick87 :smile:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message