brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] brooklyn-server pull request: SoftLayer VLAN customizer
Date Thu, 10 Mar 2016 16:15:33 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/
    @@ -0,0 +1,192 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.location.jclouds.softlayer;
    +import java.util.concurrent.Semaphore;
    +import java.util.concurrent.TimeUnit;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import org.jclouds.compute.ComputeService;
    +import org.jclouds.compute.options.TemplateOptions;
    +import org.jclouds.softlayer.SoftLayerApi;
    +import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
    +import org.jclouds.softlayer.domain.VirtualGuest;
    +import org.jclouds.softlayer.features.VirtualGuestApi;
    +import org.jclouds.softlayer.reference.SoftLayerConstants;
    +import org.apache.brooklyn.api.entity.Entity;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.core.location.LocationConfigKeys;
    +import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
    +import org.apache.brooklyn.location.jclouds.JcloudsLocation;
    +import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
    +import org.apache.brooklyn.util.core.task.Tasks;
    +import org.apache.brooklyn.util.javalang.Threads;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.apache.brooklyn.util.time.Duration;
    + * Configures SoftLayer provisioned VMs with the same VLAN ids across an application.
    + */
    +public class SoftLayerSameVlanLocationCustomizer extends BasicJcloudsLocationCustomizer
    +    private static final Logger LOG = LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
    +    public static final ConfigKey<String> SCOPE_UID = ConfigKeys.newStringConfigKey("softlayer.vlan.scopeUid",
    +            "The unique identifier for a Softlayer location scope that will have VMs
created in the same VLAN");
    +    public static final ConfigKey<Duration> SCOPE_TIMEOUT = ConfigKeys.newDurationConfigKey("softlayer.vlan.timeout",
    +            "The length of time to wait for a Softlayer VLAN ID", Duration.minutes(10));
    --- End diff --
    this feels like not long enough.  SL VM provisioning is often fast but not infrequently
can take 25m or more.  suggest 1 hour?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message