brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-client pull request: Add -Pno-go-client profile
Date Thu, 10 Mar 2016 09:29:31 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/4#issuecomment-194752153
  
    this is a complex way to exclude the client, and roundabout it feels as it suggests the
module is built it just defines a no-op build.  also with maven (as you've discovered with
the `activation` logic) inverting a profile is convoluted and prone to errors.
    
    do you think it would be better to exclude the module altogether if the profile is set?
    
    unfortunately to do this in the uber pom it seems there is no way to avoid listing the
modules twice, once with `brooklyn-client` and once without.  maybe the least messy way would
be to create a new pom in `brooklyn-client/pom-wrapper/` which has a default `<modules>`
list pointing at the parent but if `no-go-client` profile is set the `<modules>` list
would be empty.  wdyt? /cc @aledsage @rdowner @neykov 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message