brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-client pull request: Add -Pno-go-client profile
Date Thu, 10 Mar 2016 06:47:40 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/4#discussion_r55639789
  
    --- Diff: pom.xml ---
    @@ -50,58 +50,75 @@
             <target>all</target>
         </properties>
     
    -    <build>
    -        <plugins>
    -            <plugin>
    -                <artifactId>maven-antrun-plugin</artifactId>
    -                <version>1.8</version>
    -                <executions>
    -                    <execution>
    -                        <id>process-build-all</id>
    -                        <phase>compile</phase>
    +
    +    <profiles>
    +
    +        <profile>
    +            <id>no-go-client</id>
    +        </profile>
    +
    +        <profile>
    +            <id>go-client</id>
    +            <activation>
    +                <activeByDefault>true</activeByDefault>
    --- End diff --
    
    Will be skipped when activating any profile, not just `no-go-client`. For example when
testing (`-PIntegration`). Could use a property activator instead - see [deployTo](https://github.com/apache/brooklyn-server/blob/master/parent/pom.xml#L1779)
example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message