Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
MIME-Version: 1.0
References: <56C71754.2020004@cloudsoftcorp.com>
 <CAL7uH2ZSxM6iddntrz2v=-vrVGneY-Yxqb=Qg7-szWJ-vJZojQ@mail.gmail.com>
 <CA+gmfajd2X8_PkZiOuFC_Cz0ET5GBO7sXgTD4xZCFPXwGC=F5Q@mail.gmail.com>
 <B75722DA-8B96-4046-B91C-9C460CDC86D8@cloudsoftcorp.com>
 <CAKEvtrQTN3D0bPVPMPq7wu1N7DxG=FX83insfs5MU01Y-nSUXw@mail.gmail.com>
 <ED639B6A-7D7D-469F-930E-F91AD865215C@cloudsoftcorp.com>
 <CAL7uH2a+0i7NF_6ZB5anDi-XYunJzF5XNeovuy8r+7M1=7oCvA@mail.gmail.com>
 <1AF4BC88-4CF4-4407-B633-85047FD7652D@cloudsoftcorp.com>
 <CAL7uH2Yx71SB_N5dkfXLBCZC+oOCnZFV6artMoWzoEasEr_yOg@mail.gmail.com>
 <CA1CACF3-C477-47E8-A922-2D128D7979DD@cloudsoftcorp.com>
 <6C388FFA-0204-4453-A708-D2A2EF62F470@cloudsoftcorp.com>
 <CAEK0Ph2uyJnmNAZXY7QH+HtoAuFz0hKT5YeW-GOOJ6sGC8bv0g@mail.gmail.com>
 <86FD32F5-589C-4911-9B13-A9C55DB0A52F@cloudsoftcorp.com>
 <56CA0274.9060203@CloudsoftCorp.com>
 <CAL7uH2Z_n17NpjmK4ErFim+M7jdsLpv5yS_giz3J9sOZq1044Q@mail.gmail.com>
 <D59220F0-72BA-4303-9DC7-60684FB00E26@cloudsoftcorp.com>
 <56CA0695.9010906@CloudsoftCorp.com>
In-Reply-To: <56CA0695.9010906@CloudsoftCorp.com>
From: Andrew Kennedy <andrew.kennedy@cloudsoftcorp.com>
Date: Sun, 21 Feb 2016 20:17:59 +0000
Message-ID: 
 <CAEK0Ph26g9J4F4HdxPppiGg1xUK0aX_zS6e6KDGd_1CnofXXsA@mail.gmail.com>
Subject: Brooklyn Task Finalizer
To: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>,
	Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>,
	John McCabe <john.mccabe@cloudsoftcorp.com>
Cc: Aled Sage <aled.sage@cloudsoftcorp.com>,
	"dev@brooklyn.apache.org" <dev@brooklyn.apache.org>
Content-Type: multipart/alternative; boundary=001a11403fa6305c5c052c4d6a3b

--001a11403fa6305c5c052c4d6a3b
Content-Type: text/plain; charset=UTF-8

All,

Have you ever seen the Java 'Finalizer' thread get into a state like this:

```
"Finalizer" daemon prio=10 tid=0x00007fd13c096800 nid=0xc5ac runnable
[0x00007fc9248dc000]
   java.lang.Thread.State: RUNNABLE
at
com.google.common.util.concurrent.ForwardingFuture.isCancelled(ForwardingFuture.java:53)
at
org.apache.brooklyn.util.core.task.BasicTask.isCancelled(BasicTask.java:323)
at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:247)
at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:248)
at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:248)
at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:248)
at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:248)
        ...
        at
org.apache.brooklyn.util.core.task.Tasks.isAncestorCancelled(Tasks.java:248)
```

Essentially there were over *1000* recursive calls to the
`#isAncestorCancelled(Task)` method; which seems excessive! The calls
appear to originate from the `#finalize()` method on the `BasicTask` class,
which will normally (this is the default implementation of `TaskFinalizer`)
execute this code:

```Java
    public static final TaskFinalizer WARN_IF_NOT_RUN = new TaskFinalizer()
{
        @Override
        public void onTaskFinalization(Task<?> t) {
            if (!Tasks.isAncestorCancelled(t) && !t.isSubmitted()) {
                // ...
```

As you can see, this starts off by calling the
`#isAncestorCancelled(Task)`, which does indeed make a recursive call to
itself if it finds an ancestor. What I _couldn't_ work out is why the call
sequence never terminates? The `submittedByTask` is what is checked in the
recursive call, and there _is_ a null check for the returned `Task` object
(from `#getSubmittedByTask()`) that is used as the ancestor. I did wonder
if there might be a problem with the following line, that sets the
submitting task in `BasicTask#setSubmittedByTask(Task)`:

```Java
    submittedByTask = (Maybe)Maybe.softThen((Task)task,
(Maybe)Maybe.of(BasicTask.newGoneTaskFor(task)));
```

So, this will create a new empty `Task` object if `task` has been garbage
collected, I believe. But I still can't see how this might result in the
continued recursive calls.

Anyway, if anyone has insight into this please let me know, as I am worried
that it is causing stability issues when running Brooklyn.

Andrew.
-- 

Andrew Kennedy ; Founder clocker.io project ; @grkvlt ; Cloudsoft

--001a11403fa6305c5c052c4d6a3b--