Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6D1A17658 for ; Tue, 26 Jan 2016 13:08:54 +0000 (UTC) Received: (qmail 9584 invoked by uid 500); 26 Jan 2016 13:08:54 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 9552 invoked by uid 500); 26 Jan 2016 13:08:54 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 9541 invoked by uid 99); 26 Jan 2016 13:08:54 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 13:08:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9D1D4C0D80 for ; Tue, 26 Jan 2016 13:08:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.427 X-Spam-Level: X-Spam-Status: No, score=0.427 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id suMQsS0MSqPa for ; Tue, 26 Jan 2016 13:08:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id E0C6D43A84 for ; Tue, 26 Jan 2016 13:08:46 +0000 (UTC) Received: (qmail 4960 invoked by uid 99); 26 Jan 2016 13:07:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 13:07:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 65D9BE0092; Tue, 26 Jan 2016 13:07:31 +0000 (UTC) From: aledsage To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Create Password Sensor Content-Type: text/plain Message-Id: <20160126130731.65D9BE0092@git1-us-west.apache.org> Date: Tue, 26 Jan 2016 13:07:31 +0000 (UTC) Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-175003056 @duncangrant Looks good. For your question about yaml tests, you need to put the test in `brooklyn-camp` (e.g. near `brooklyn-server/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/`). Unfortunately that test package is getting too big - we'll need to split out that package at some point. You could create a new `org.apache.brooklyn.camp.brooklyn.policy` package (no strong feelings at this point). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---