Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-950-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-950-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Windows script files
Content-Type: text/plain
Message-Id: <20160115230450.DAEFCE045B@git1-us-west.apache.org>
Date: Fri, 15 Jan 2016 23:04:50 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/950#discussion_r49915992
  
    --- Diff: brooklyn-server/software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java ---
    @@ -66,8 +66,38 @@
                 "Size of file chunks (in bytes) to be used when copying a file to the remote server", 
                 1024);
     
    +    /**
    +     * Executes a Native Windows command.
    +     * It is creating a new Shell on the destination host each time it is being called.
    +     * @param command
    +     * @since 0.2
    +     */
    +    WinRmToolResponse executeCommand(String command);
    +
    +    /**
    +     * Executes a Power Shell command.
    +     * It is creating a new Shell on the destination host each time it is being called.
    +     * @param psCommand
    +     * @since 0.2
    +     */
    +    WinRmToolResponse executePsCommand(String psCommand);
    +
    +    /**
    +     * Execute a list of Windows Native commands as one command.
    +     * The method translates the list of commands to a single String command with a <code>"\r\n"</code> delimiter and a terminating one.
    +     * @param commands
    +     * @deprecated since 0.2; Use the {@link #executeCommand(String)} instead and transform your commands list explicitly
    +     */
    +    @Deprecated
         WinRmToolResponse executeScript(List<String> commands);
    --- End diff --
    
    @bostko see @neykov 's comments in https://github.com/cloudsoft/winrm4j/pull/2, saying "we should keep the `(List<String>)`...".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---