Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: johnmccabe <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1143-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1143-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: clean up app spec
 unwrapping
Content-Type: text/plain
Message-Id: <20160114181513.26233E3874@git1-us-west.apache.org>
Date: Thu, 14 Jan 2016 18:15:13 +0000 (UTC)

Github user johnmccabe commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1143#issuecomment-171727240
  
    @ahgittin looks like its still not playing nicely with template 4, I'm seeing VanillaSoftwareProcess is wrapped with a BasicApplication. The enrichers/sensors that are being set in the memberSpec then get applied to the BA rather than the VSP - all deploys ok, but if you try to connect to the Nginx Proxy endpoint you'll get a 404 as this is whats getting added to the `proxy.serverpool.targets`:
    
    ```
    {"BasicApplicationImpl{id=z1rYauyy}":null}
    ```
    
    Also the `my.message` config doesn't get overwritten (still `my.message` rather than `part of the cluster`).
    
    This is what we'd hacked around in #1135 - having to add cluster specific sensors etc to the template 2 app felt like a step backwards - the ability to layer on cluster-smarts to a non-cluster app was awesome


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---